yellowadmin/pp-tcms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: comment to test run's case (#390)

Browse Source
This commit is contained in:
kimatata
2026-02-23 12:26:07 +09:00
committed by GitHub
parent 1f4ac0ae7b
commit a9674c81ab
27 changed files with 1045 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
backend/middleware/verifyVisible.js
View File

@@ -4,6 +4,7 @@ import defineProject from '../models/projects.js';
import defineFolder from '../models/folders.js';
import defineCase from '../models/cases.js';
import defineRun from '../models/runs.js';
import defineRunCase from '../models/runCases.js';
export default function verifyVisibleMiddleware(sequelize) {
/**
@@ -16,8 +17,8 @@ export default function verifyVisibleMiddleware(sequelize) {
return res.status(400).json({ error: 'projectId is required' });
}
const isVisble = await isVisible(projectId, req.userId);
if (isVisble) {
const visible = await isVisible(projectId, req.userId);
if (visible) {
next();
return;
}
@@ -44,8 +45,8 @@ export default function verifyVisibleMiddleware(sequelize) {
return res.status(404).send('failed to find projectId');
}
const isVisble = await isVisible(projectId, req.userId);
if (isVisble) {
const visible = await isVisible(projectId, req.userId);
if (visible) {
next();
return;
}
@@ -80,8 +81,8 @@ export default function verifyVisibleMiddleware(sequelize) {
return res.status(404).send('failed to find projectId');
}
const isVisble = await isVisible(projectId, req.userId);
if (isVisble) {
const visible = await isVisible(projectId, req.userId);
if (visible) {
next();
return;
}
@@ -108,8 +109,8 @@ export default function verifyVisibleMiddleware(sequelize) {
return res.status(404).send('failed to find projectId');
}
const isVisble = await isVisible(projectId, req.userId);
if (isVisble) {
const visible = await isVisible(projectId, req.userId);
if (visible) {
next();
return;
}
@@ -117,6 +118,51 @@ export default function verifyVisibleMiddleware(sequelize) {
return res.status(403).json({ error: 'Forbidden' });
}
async function verifyProjectVisibleFromCommentableId(req, res, next) {
const commentableType = req.params.commentableType || req.query.commentableType;
const commentableId = req.params.commentableId || req.query.commentableId;
if (!commentableType || !commentableId) {
return res.status(400).json({ error: 'commentableType and commentableId are required' });
}
if (commentableType === 'Run') {
// not implemented yet
next();
return;
} else if (commentableType === 'Case') {
// not implemented yet
next();
return;
} else if (commentableType === 'RunCase') {
const RunCase = defineRunCase(sequelize, DataTypes);
const runCaseId = req.params.commentableId || req.query.commentableId;
if (!runCaseId) {
return res.status(400).json({ error: 'runCaseId is required' });
}
const runCase = await RunCase.findByPk(runCaseId);
const runId = runCase && runCase.runId;
if (!runId) {
return res.status(404).send('failed to find runId');
}
const Run = defineRun(sequelize, DataTypes);
const run = await Run.findByPk(runId);
const projectId = run && run.projectId;
if (!projectId) {
return res.status(404).send('failed to find projectId');
}
const visible = await isVisible(projectId, req.userId);
if (visible) {
next();
return;
}
} else {
return res.status(400).json({ error: 'unsupported commentableType' });
}
}
async function isVisible(projectId, userId) {
const Project = defineProject(sequelize, DataTypes);
const Member = defineMember(sequelize, DataTypes);
@@ -158,5 +204,6 @@ export default function verifyVisibleMiddleware(sequelize) {
verifyProjectVisibleFromFolderId,
verifyProjectVisibleFromCaseId,
verifyProjectVisibleFromRunId,
verifyProjectVisibleFromCommentableId,
};
}